Re: [PATCH 2/3] generic-ipi: remove kmalloc()

From: Rusty Russell
Date: Wed Feb 18 2009 - 00:31:24 EST


On Wednesday 18 February 2009 08:29:06 Peter Zijlstra wrote:
> Remove the use of kmalloc() from the smp_call_function_*() calls.

This patch is actually quite nice. Not sure it's correct, but it's neat :)

One minor quibble:

> + data = &per_cpu(csd_data, me);

"data = &__get_cpu_var(csd_data);" is slightly preferred. A few less cycles.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/