[PATCH] sx.c: fix dbl statement if - add missing braces

From: Ilpo Järvinen
Date: Wed Feb 18 2009 - 08:53:05 EST



Caused by 736d54533aed (sx.c: fix missed unlock_kernel()
on error path in sx_fw_ioctl()). You guys keep breaking
things this way in every single kernel release in at least
couple of places... :-(

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxx>
Cc: Dan Carpenter <error27@xxxxxxxxx>
---
drivers/char/sx.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/char/sx.c b/drivers/char/sx.c
index f146e90..d7c4165 100644
--- a/drivers/char/sx.c
+++ b/drivers/char/sx.c
@@ -1746,9 +1746,10 @@ static long sx_fw_ioctl(struct file *filp, unsigned int cmd,
sx_dprintk(SX_DEBUG_FIRMWARE, "returning type= %ld\n", rc);
break;
case SXIO_DO_RAMTEST:
- if (sx_initialized) /* Already initialized: better not ramtest the board. */
+ if (sx_initialized) { /* Already initialized: better not ramtest the board. */
rc = -EPERM;
break;
+ }
if (IS_SX_BOARD(board)) {
rc = do_memtest(board, 0, 0x7000);
if (!rc)
--
1.5.2.2