Re: [RFC][PATCH 2/2] tracing/function-graph-tracer: providedocumentation for the function graph tracer

[Ingo Molnar]

btw., a minor trace-output observation. We currently have this 
default output:

# tracer: function_graph
#
# CPU  DURATION                  FUNCTION CALLS
# |     |   |                     |   |   |   |

 0)               |  sys_open() {
 0)               |    do_sys_open() {
 0)               |      getname() {
 0)               |        kmem_cache_alloc() {
 0)   1.382 us    |          __might_sleep();
 0)   2.478 us    |        }

Wouldnt this tweaked version look even nicer:

#
# [ tracer: function_graph ]
#
 CPU)  <duration>   |  <function-name>
 ..............................................
   0)               |  sys_open() {
   0)               |    do_sys_open() {
   0)               |      getname() {
   0)               |        kmem_cache_alloc() {
   0)   1.382 us    |          __might_sleep();
   0)   2.478 us    |        }


Changes:

 1) Added an empty '#' line to the head. Looks nicer because 
    the comment is now symmetric.

 2) Shifted of the CPU field two positions to the left. Better 
    for paste-ability and makes the 'CPU)' header fit as well.

 3) Changed the field description in the header portion to a 
    standard <field> notation.

 4) added the '....' line to create a table.

Hm?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/