Re: [PATCH 2/3] [RESEND] binfmt_script: rewrite usingparse_shell_args()

[Kirill A. Shutemov]

On Wed, Feb 18, 2009 at 03:29:56PM +0000, Matthew Garrett wrote:
> On Wed, Feb 18, 2009 at 05:22:52PM +0200, Kirill A. Shutemov wrote:
> > On Wed, Feb 18, 2009 at 03:16:16PM +0000, Matthew Garrett wrote:
> > > On Wed, Feb 18, 2009 at 05:16:01PM +0200, Kirill A. Shutemov wrote:
> > > > parse_shell_args() allows to use more than one argument in shebang.
> > > 
> > > As mentioned before, this breaks userspace ABI.
> > 
> > Do you have real world example of breakage?
> 
> Have you checked every script on every Linux system?

Ok, I've looked into other kernels(*BSD and OpenSolaris). None of them
parse arguments in shebang. Before 6.x FreeBSD parsed arguments, but then
they changed behaviour.

So, this patch is wrong. What about patch #3?

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.org/

Attachment: signature.asc
Description: Digital signature