Re: [PATCH] cpufreq: Change link order of x86 cpufreq modules

[Dave Jones]

On Wed, Feb 18, 2009 at 07:31:37PM +0100, Ingo Molnar wrote:
 > 
 > * Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
 > 
 > > Change the link order of the cpufreq modules to ensure that they're 
 > > probed in the preferred order when statically linked in.
 > >     
 > > Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx>
 > > 
 > > diff --git a/arch/x86/kernel/cpu/cpufreq/Makefile b/arch/x86/kernel/cpu/cpufreq/Makefile
 > > index 560f776..509296d 100644
 > > --- a/arch/x86/kernel/cpu/cpufreq/Makefile
 > > +++ b/arch/x86/kernel/cpu/cpufreq/Makefile
 > > @@ -1,6 +1,11 @@
 > > +# Link order matters. K8 is preferred to ACPI because of firmware bugs in early
 > > +# K8 systems. ACPI is preferred to all other hardware-specific drivers.
 > > +# speedstep-* is preferred over p4-clockmod.
 > 
 > Nice fix! Where does this information come from? Distro module 
 > ordering magic? It's rather non-trivial.

it's a mess of shell script right now.
See /etc/init.d/cpuspeed on Fedora for eg. 

 > (small style nit: the first line in the Makefile is overlong.)
 
I'll fix that up before merging.

Thanks Matthew, queued for .30

	Dave 


-- 
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/