Re: [PATCH] MMC: core/core.c: fixed: delayed_work was nevercancelled

From: Pierre Ossman
Date: Wed Feb 18 2009 - 15:19:58 EST


On Tue, 17 Feb 2009 15:32:10 +0200
Jorg Schummer <ext-jorg.2.schummer@xxxxxxxxx> wrote:

> The delayed work item mmc_host.detect is now cancelled before flushing
> the work queue. This takes care of cases when delayed_work was scheduled
> for mmc_host.detect, but not yet placed in the work queue.
>
> Signed-off-by: Jorg Schummer <ext-jorg.2.schummer@xxxxxxxxx>
> ---

Do the cancel in the caller instead. The flush routine is supposed to
mimic the global workqueue.

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/