Re: [PATCH] spi-gpio: Sanitize MISO bitvalue

From: David Brownell
Date: Wed Feb 18 2009 - 19:30:18 EST


On Wednesday 18 February 2009, Andrew Morton wrote:
> If this function is speed-critical (which is what David's comment
> implies) then perhaps this should be "fixed" by tightening up the
> (presently apparently undocumented) interface?  And then speeding up
> all the other getmiso() implementations?

All the per-bit GPIO functions can be speed-critical,
which is why they use the zero/nonzero convention
instead of demanding extra instructions to switch to
the zero/one convention.

This particular function needs the zero/one convention;
in that respect it's unusual.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/