Re: [PATCH] cpuset: various documentation fixes and updates

From: Li Zefan
Date: Thu Feb 19 2009 - 00:41:36 EST


>> If a cpuset has its 'cpus' modified, then each task in that cpuset
>> will have its allowed CPU placement changed immediately. Similarly,
>> -if a tasks pid is written to a cpusets 'tasks' file, in either its
>> -current cpuset or another cpuset, then its allowed CPU placement is
>> -changed immediately. If such a task had been bound to some subset
>> -of its cpuset using the sched_setaffinity() call, the task will be
>> -allowed to run on any CPU allowed in its new cpuset, negating the
>> -affect of the prior sched_setaffinity() call.
>> +if a tasks pid is written to another cpusets 'tasks' file, then its
>
> task's pid cpuset's
>

Paul Jackson is the original author of this document, and he once said he
doesn't like to use foo's but is used to use foos, so I think I'm not
going to correct them all through this doc, at least not in this patch. :)

>> +allowed CPU placement is changed immediately. If such a task had been
>> +bound to some subset of its cpuset using the sched_setaffinity() call,
>> +the task will be allowed to run on any CPU allowed in its new cpuset,
>> +negating the affect of the prior sched_setaffinity() call.
>
> effect
>

Will fix.

>> + - via the cpuset file system directly, using the various cd, mkdir, echo,
>> + cat, rmdir commands from the shell, or there equivalent from C.
>
> their

Will fix.

>> -mount -t cgroup -ocpuset X /dev/cpuset
>> +mount -t cgroup -ocpuset,noprefix X /dev/cpuset
>
> I'm used to "-o options_list"... I guess either is OK.
>

Actually I'm used to "-o opt" too.

Thanks for the review!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/