Re: [PATCH 08/10] vmalloc: add un/map_kernel_range_noflush()

[Nick Piggin]

On Wednesday 18 February 2009 23:04:34 Tejun Heo wrote:
> Impact: two more public map/unmap functions
>
> Implement map_kernel_range_noflush() and unmap_kernel_range_noflush().
> These functions respectively map and unmap address range in kernel VM
> area but doesn't do any vcache or tlb flushing.  These will be used by
> new percpu allocator.

Hmm... I have no real issues with this, although the caller is going
to have to be very careful not to introduce bugs (which I'm sure you
were ;)).

Maybe can you add comments specifying the minimum of which flushes
are required and when, to scare people away from using them?


>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> ---
>  include/linux/vmalloc.h |    3 ++
>  mm/vmalloc.c            |   58
> ++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 58
> insertions(+), 3 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/