Re: [PATCH] staging/pohmelfs: fix kconfig dependencies

From: Evgeniy Polyakov
Date: Thu Feb 19 2009 - 15:44:19 EST


On Wed, Feb 18, 2009 at 01:01:34PM -0800, Randy Dunlap (randy.dunlap@xxxxxxxxxx) wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> pohmelfs wants to use CONNECTOR, so it selects CONNECTOR,
> but when CONFIG_NET is not enabled, connector.c will not build,
> since select does not follow the dependency chain.
> Selecting NET is not a good idea, since that would build lots
> of code that someone seemingly didn't want to build/store
> and kconfig shouldn't do that behind someone's back.
>
> pohmelfs should depend on NET since it uses network interfaces.

Thank you Randy, I will queue it into the local tree also since Greg
pulled it into staging already. I first thought to make the whole
network filesystems config option to make depending on the network.

--
Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/