Re: [PATCH 2/4] forget_original_parent: do not abusechild->ptrace_entry

From: Roland McGrath
Date: Thu Feb 19 2009 - 21:28:48 EST


> - rename ptrace_dead to dead_childs.

s/dead_childs/dead_children/

> Actually, I don't understand why do we notify /sbin/init when we
> reparent a zombie, probably it is better to reap it unconditionally.

It is traditional behavior. It gives the init implementation the option to
report/log/analyze the details of abandoned zombies. (Whether or not that
really seems useful, there is no good reason to restrict the possibility.)

> +/*
> +* Any that need to be release_task'd are put on the @dead list.
> + */

Missing leading space on the second comment lien.

Modulo those cosmetic things, ACK on this.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/