Re: [PATCH] x86: remove unneeded endless loop in BUG()

[Petr Tesarik]

H. Peter Anvin pÃÅe v Ät 19. 02. 2009 v 12:48 -0800:
> Jeremy Fitzhardinge wrote:
> > 
> > There's no reason to expect an "asm volatile" to stay put; the 
> > "volatile" has nothing to do with preventing code motion.  The only way 
> > to make an asm stick in one place is with data dependencies, and I'm not 
> > sure what the dependency for __builtin_trap might be.  I'm guessing its 
> > a "memory" clobber, but that's pure guesswork.
> > 
> 
> I looked through this with HJL; the bottom line is that although it 
> probably would work, it's not worth it.
> 
> I submitted GCC bug 39252 to get __builtin_not_reached(); instead.

Thank you! I like it this way, too.

Petr Tesarik


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/