Re: Incorrect #ifdef in arch/x86/mm/pat.c

From: Ingo Molnar
Date: Fri Feb 20 2009 - 17:59:23 EST



* Dheeraj Reddy <dheerajr@xxxxxxxxx> wrote:

> Hello there,
> The checks for reading /dev/kmem and /dev/mem in arch/x86/mm/pat.c seems to
> be incorrect when CONFIG_STRICT_DEVMEM is set.
> Following patch corrects it.
> The check should always return 1 when CONFIG_STRICT_DEVMEM is not defined,
> similar to what is in drivers/char/mem.c

no - see the comment in pat.c:

/* This check is done in drivers/char/mem.c in case of STRICT_DEVMEM*/

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/