Re: commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 breaks rlogin

From: David Miller
Date: Sun Feb 22 2009 - 02:53:39 EST


From: "Ilpo Järvinen" <ilpo.jarvinen@xxxxxxxxxxx>
Date: Sat, 21 Feb 2009 20:54:11 +0200 (EET)

> On Sat, 21 Feb 2009, Herbert Xu wrote:
>
> > On Mon, Feb 09, 2009 at 03:28:09PM +0200, Ilpo Järvinen wrote:
> > >
> > > Yes, that should work too except the gcc catchable typo.
> >
> > Thanks, so let's try again for net-next:
> >
> > tcp: Always set urgent pointer if it's beyond snd_nxt
...
> I thought this through already at the last time... so I think it really
> should work in all cases I could think of (including the below window
> probes whose existance is not very obvious before they bite back :-)):
>
> Acked-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxx>
>
> But I mostly agree with Linus that URG is legacy that would be good
> to just deprecate instead of trying to "fix" it.

Sure, but I'll give Herbert one more chance :-)

Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/