Re: Fwd: PCF8583 not detected on RiscPC

[Alessandro Zummo]

On Sun, 22 Feb 2009 11:26:54 +0000
Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:


> I refer you to bb71f99f8daefb4a2c2441298bc127aaff9af947 and the
> discussion resulting from that commit, and changed in your commit
> 09a21e56dc3767ce444e21c1383d587b261af13c.

 As I said, the driver was born without the additional
 depend. 

 http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=9c0c570576d02000063e28faadcce8c07396755d

 You then added it in

 http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=bb71f99f8daefb4a2c2441298bc127aaff9af947
 
 crating an arch specific driver from a driver that
 was mostly generic. I wasn't in Cc and I didn't noticed at that time.

  If you had it sent to me I would have told you that it
 was plain wrong. 

 When I did the Kconfig cleanup I noticed an additional
 dependency and removed it. This was not done because I don't
 like acorn, the arm stuff (to which I have too contributed)
 or anyone else.


> >  I don't know who converted the acorn platform to
> >  use it and I can't care less. Who did should have checked the driver 
> >  for compatibility with his own platform before migrating from the driver under
> >  drivers/char/ .
> 
> Which bit of "it used to work" did you miss?  At the time of converesion,
> it was checked and after some initial trivial bug fixing and it was
> working, and continued to work up until this recent breakage.

 I was discussing about the non-platform-specific nature of the driver.

 The breakage happened because the whole i2c stack has been revamped.
 It has been discussed for a long time and we have spent much effort
 to ensure that everything was correct. However we can all fail.
 I have checked all the files in the arch directory searching for
 i2c users. acorn was not there and I missed it.

 That said, the kernel is evolving continuously and once you reported
 the problem Jean and I actively worked to fix it.

 I'm not stating that we had not a problem or that the there wasn't
 a breakage. Only that the fault is not in the driver itself but
 on how the platform uses it. And that's why I refuse a revert-everything
 approach.

 If a better communication approach had been established in the past
 this probably wouldn't have happened.


> >  As far as I can see with git log, you applied changes to the driver
> >  multiple times, without having me in Cc nor G. Liakhovetski (who did
> >  the port).
> 
> I don't add CC entries to commits, so you can't make that assumption.

 Please check your archive, but I'm pretty sure I would have noticed
 an email with a subject. I don't see it in my archives nor in the 
 mailing list.

 [ARM] rtc-pcf8583: Final fixes for this RTC on RiscPC

 If you did sent it to me or to the list and I hadn't noticed, I beg your pardon.

> However, I did talk to Guennadi around the time of those changes about
> some of the issues therein, in particular adding back the I2C address of
> the PCF8583.

 So you and Guennadi knew but not everyone else.
 
> Most of those other changes were trivial bug fixes, and I do apologise
> for not copying you with those.

 I accept the apologies but you don't need to copy me for those, we
 have trivial@ for those, which usually Ccs me. And there's Andrew who
 kindly gives a look at everything.

 But when things are important I do appreciate to see it at the proper time.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/