Re: [PATCH] Remove some pointless conditionals before kfree() inkernel/cgroup.c

From: Li Zefan
Date: Mon Feb 23 2009 - 03:32:41 EST


Jesper Juhl wrote:
> Hi,
>
> Here's a small patch for kernel/cgroup.c
>
> Removes a few pointless tests of pointer == 0 before kfree() in
> kernel/cgroup.c.
> If the pointer we hand to kfree() is 0, then kfree() is a noop, so there
> is no need to test.
>
> Reduces object file size a bit :
>
> Before:
> $ size kernel/cgroup.o
> text data bss dec hex filename
> 21593 7804 4924 34321 8611 kernel/cgroup.o
> After:
> $ size kernel/cgroup.o
> text data bss dec hex filename
> 21537 7744 4924 34205 859d kernel/cgroup.o
>
> and source file size shrinks a bit too - always nice.
>
>
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

Reviewed-by: Li Zefan <lizf@xxxxxxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/