Re: [RFC][PATCH 2/2] PM: Rework handling of interrupts duringsuspend-resume

From: Benjamin Herrenschmidt
Date: Mon Feb 23 2009 - 05:15:22 EST


On Mon, 2009-02-23 at 01:22 -0800, Eric W. Biederman wrote:
> Ingo Molnar <mingo@xxxxxxx> writes:
>
>
> > I think this aspect has been well-understood during the
> > discussion of this topic and it's just a slightly misleading
> > changelog.
>
> As I was a member of that discussion I did not see that.
>
> It took me several passes through the patches to realize
> the goal is to allow drivers to be able to sleep while they
> are in their late pm shutdown routines.
>
> Why we want this I don't know. But it seems simple enough
> to implement, and it makes it harder to get the late pm
> suspend routines wrong, which is always good.

To simplify (it's really all in the discussion we had the last few
weeks) It boils down to being able to do the proper ACPI calls (which
require core interrupts to be on, ie, ACPI uses mutexes, sleeps, etc...)
after we have saved and before we restore the PCI config space, in the
late suspend or early resume stages of devices.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/