Re: [PATCH -mm] tracing: Fix section mismatch in trace_hw_branches.c

[Markus Metzger]

On Sun, Feb 22, 2009 at 5:22 PM, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> On Sun, Feb 22, 2009 at 07:33:08PM +0600, Rakib Mullick wrote:
>> On 2/21/09, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

>> >  So, unless I missed something, this patch seems to me very dangerous.
>> >  The init and reset callbacks of a tracer can be called at any time, not only
>> >  on initcalls time (__init functions are freed from memory after the middle stage
>> >  of the boot).
>> >  With this patch, on UP we will dereference freed memory while activating this tracer.
>> If the init and reset callbacks of a tracer can be called regardless
>> of cpu hotpluging then it is. If the tracer's init or reset doesn't
>> rely on cpuhotplug then it shouldn't use it.
>> There's a another way to fix the warning is by remove __cpuinitdata
>> from bts_hotcpu_notifier.
[...]
> But removing __cpuinitdata will mean a kind of waste of memory (though it's only
> a little struct).

Plus the hotplug handler function. It's still not much.

I'll send out a patch following Frederic's suggestion to register the
hotplug notifier once in init.

thanks and regards,
markus.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/