Re: [PATCH] pciehp: Handle interrupts that happen during initialization.

From: Eric W. Biederman
Date: Mon Feb 23 2009 - 06:08:28 EST


Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx> writes:

> Ok, I understood what is happening. Could you try the following patch?
> It is currently in Jesse's linux-next.
>
> http://marc.info/?l=linux-pci&m=123364118418484&w=2
>
> BTW, I don't think surprise removal is well tested.

That patch should guarantee that we don't loop forever, and if we are
going to loop that looks like a reasonable way to handle it.

When I start working on what is the most maintainable way to implement
merge my hotplug driver work I will come back and test this.

At the moment it appears that it will at least suffer from detecting a
presence change event with a device showing up. Before pci structure
for the device is removed. I seem to recall some dead locks on the
pciehp work queue hotunplugging a hotplug driver as well.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/