Re: [RFC][PATCH 2/2] PM: Rework handling of interrupts duringsuspend-resume

From: Benjamin Herrenschmidt
Date: Mon Feb 23 2009 - 15:52:48 EST



> That property can be implied in the function name:
>
> device_power_down_irq_disable(PMSG_SUSPEND);
>
> Open-coding it, if it looks the same in all the cases just
> increases the chances that someone somewhere copies them
> incorrectly.

No. Some archs need to do "special" things at the irq disable point,
leave it open coded in the caller please.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/