RE: [patch 1/6] x86, ftrace, hw-branch-tracer: support hotplug cpus

[Metzger, Markus T]

>-----Original Message-----
>From: Nathan Lynch [mailto:ntl@xxxxxxxxx]
>Sent: Tuesday, February 24, 2009 10:46 PM
>To: Ingo Molnar
>Cc: Metzger, Markus T; linux-kernel@xxxxxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; hpa@xxxxxxxxx;
>markus.t.metzger@xxxxxxxxx; srostedt@xxxxxxxxxx
>Subject: Re: [patch 1/6] x86, ftrace, hw-branch-tracer: support hotplug cpus
>
>On Tue, 24 Feb 2009 20:36:22 +0100
>Ingo Molnar <mingo@xxxxxxx> wrote:
>
>>
>> * Markus Metzger <markus.t.metzger@xxxxxxxxx> wrote:
>>
>> > Support hotplug cpus.
>>
>> > +static int __cpuinit bts_hotcpu_handler(struct notifier_block *nfb,
>> > +				     unsigned long action, void *hcpu)
>> > +{
>> > +	unsigned int cpu = (unsigned long)hcpu;
>> > +
>> > +	mutex_lock(&bts_tracer_mutex);
>>
>> This is buggy: CPU hotplug handlers must not sleep (they are
>> called with irqs disabled)
>
>I don't think that is the case; the cpu notifier chains are "raw", not
>atomic, and the cpu hotplug core doesn't disable irqs while processing
>the chains afaict.  And there are several current examples of cpu
>hotplug callbacks performing sleeping operations (slab and slub,
>page_alloc, probably many others).

The hotplug code uses mutexes around raw_notifier_call_chain() calls in
all but one case:
  For CPU_STARTING_FROZEN, the caller has interrupts disabled.

I guess I could check the notification reason before grabbing the lock
in the handler.

regards,
markus.
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/