Re: [PATCH 14/15] bitops: Change the bitmap index from int to unsigned long [frv]

[David Howells]

Justin Chen <jchen@xxxxxxxxxxxxxxxxxx> wrote:

> Change the index to unsigned long in all bitops for [frv]
> 
> Signed-off-by: Justin Chen <justin.chen@xxxxxx>
> Reviewed-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>

Mostly okay, apart from:

> -static inline int __constant_test_bit(int nr, const volatile void * addr)
> +static inline int
> +__constant_test_bit(unsigned long nr, const volatile void *addr)

Please move the return type onto the next line also.  Other than that:

Acked-by: David Howells <dhowells@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/