On Wed, Feb 25, 2009 at 06:02:07PM -0800, H. Peter Anvin wrote:Steven Rostedt wrote:This patch creates a copy_word_from_user function that can copyI have a bit of an issue with the naming... at least *I* read this as copying a machine word, which made me wonder why you didn't just use "get_user". I would suggest copy_token_from_user or something like that.
a space delimited word from user space. This puts the code in
a new lib/uaccess.c file. This keeps the code in a single location
and may be optimized in the future.
-hpa
That was the first impression I had too (the sense of a machine word).
But token seems to me imprecise as well, too much generic.
Well, since it is well commented, I guess it's not so much an issue...