Re: [PATCH 1/4] uaccess: add copy_word_from_user

[H. Peter Anvin]

Frederic Weisbecker wrote:
> On Wed, Feb 25, 2009 at 06:02:07PM -0800, H. Peter Anvin wrote:
> > Steven Rostedt wrote:
> > > This patch creates a copy_word_from_user function that can copy
> > > a space delimited word from user space. This puts the code in
> > > a new lib/uaccess.c file. This keeps the code in a single location
> > > and may be optimized in the future.
> > I have a bit of an issue with the naming... at least *I* read this as  
> > copying a machine word, which made me wonder why you didn't just use  
> > "get_user".  I would suggest copy_token_from_user or something like that.
> >
> > 	-hpa
>
> That was the first impression I had too (the sense of a machine word).
> But token seems to me imprecise as well, too much generic.
>
> Well, since it is well commented, I guess it's not so much an issue...

Well, "word" has the problem that someone looking at a call site is 
likely to get the wrong idea.  "token" may make them confused, but that 
means they'll try to look it up.  However, I'm sure we could do better.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/