Re: [PATCH] net headers: export dcbnl.h

[Chris Leech]

On Fri, 2009-02-27 at 02:46 -0800, David Miller wrote:
> From: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Date: Fri, 27 Feb 2009 06:55:06 +0100
> 
> > On Thu, Feb 26, 2009 at 04:46:35PM -0800, Chris Leech wrote:
> > > The DCB netlink interface is required for building the userspace tools
> > > available at e1000.sourceforge.net
> > 
> > Hmmm, is that file ready for export....
> > 
> > >From dcbnl.h:
> > #ifndef __LINUX_DCBNL_H__
> > #define __LINUX_DCBNL_H__
> > 
> > #define DCB_PROTO_VERSION 1
> > 
> > struct dcbmsg {
> >         unsigned char      dcb_family;
> >         __u8               cmd;
> >         __u16              dcb_pad;
> > };
> > 
> > 1) It uses __u8/__u16 so it would be nice it is included <linux/types.h>
> > so these are actually defined.

OK, I'll send again with a patch to add <linux/types.h>

> > 2) Why does it use "unsigned char" for one member and __u8 for another.
> > It looks inconsistent.

My guess is that the first member was made to be unsigned char to match
struct rtgenmsg, but other rtnetlink users define family as __u8
(fib_rule_hdr, ndmsg, ndtmsg) so it should be OK to change it.

> > We export headers that are much worse but we better raise the bar a little.
> 
> Agreed, we should sort out these issues before exporting.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/