Re: [PATCH 0/4] cgroups: show correct file mode

[Mike Waychison]

KAMEZAWA Hiroyuki wrote:
> On Mon, 2 Mar 2009 16:15:51 -0800
> Paul Menage <menage@xxxxxxxxxx> wrote:
>
> > On Mon, Mar 2, 2009 at 4:09 PM, KAMEZAWA Hiroyuki
> > <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> > >        int mode;
> > >        if (cft->mode)
> > >                mode = cft->mode;
> > >        else if (cft->write_xxx || .....)
> > >                mode = 0644;
> > >        else
> > >                mode = 0444;
> > Almost:
> >
> > int mode;
> > if (cft->mode) {
> >   mode = cft->mode;
> > } else {
> >   if (cft->write_xxx || ....)
> >     mode |= 0600;

0200 ?

> >   if (cft->read_xxx || ...)
> >     mode |= 0444;
> > }
> Oh, I see. But int mode=0, at first ;)
> I have no objections but please forgive subsys to set mode=0644 explicitly.
>
> Thanks,
> -Kame
>
> _______________________________________________
> Containers mailing list
> Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
> https://lists.linux-foundation.org/mailman/listinfo/containers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/