Re: [PATCH 1/1] Char: moxa, fix refcounting in moxa_poll_port

[Jiri Slaby]

Restoring CCs.

On 15.3.2009 11:55, Alan Cox wrote:
> On Sun, 15 Mar 2009 10:36:08 +0100
> Jiri Slaby<jirislaby@xxxxxxxxx>  wrote:
>
> > There is missing tty_kref_put on some paths in moxa_poll_port,
> > although the reference is always taken. Fix it.
> >
> > Signed-off-by: Jiri Slaby<jirislaby@xxxxxxxxx>
> > Reported-by: Jan 'Yenya' Kasprzak<kas@xxxxxxxxxx>
> > Cc: Alan Cox<alan@xxxxxxxxxxxxxxxxxxx>
>
> Acked-by: Alan Cox<alan@xxxxxxxxxxxxxxxxxxx>

BTW the same sha, the change in isicom_shutdown_port doesn't seem to be 
quite right too. Well, the change itself is, but not in the code 
context. The tty is used even after tty_port_tty_set(NULL). This is 
wrong, isn't it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/