Re: [PATCH 12/24] x86-64: remove PGE from must-have feature list

[Jeremy Fitzhardinge]

H. Peter Anvin wrote:
> > --- a/arch/x86/include/asm/required-features.h
> > +++ b/arch/x86/include/asm/required-features.h
> > @@ -50,7 +50,7 @@
> >  #ifdef CONFIG_X86_64
> >  #define NEED_PSE	0
> >  #define NEED_MSR	(1<<(X86_FEATURE_MSR & 31))
> > -#define NEED_PGE	(1<<(X86_FEATURE_PGE & 31))
> > +#define NEED_PGE	0
> >  #define NEED_FXSR	(1<<(X86_FEATURE_FXSR & 31))
> >  #define NEED_XMM	(1<<(X86_FEATURE_XMM & 31))
> >  #define NEED_XMM2	(1<<(X86_FEATURE_XMM2 & 31))
> >     
>
> This should be conditionalized on CONFIG_PARAVIRT, since doing this
> removes real-hardware optimimizations.
>   

OK.  Can do the same for PSE.

   J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/