Re: [PATCH] snd: aica - fix annoying compiler warning

[Takashi Iwai]

At Sun, 15 Mar 2009 22:05:40 +0000,
Adrian McMenamin wrote:
> 
> Cast pointer to data member of struct firmware as a void to end an
> annoying compiler warning.
> 
> fix annoying compiler warning
> 
> Signed-off-by: Adrian McMenamin <adrian@xxxxxxxxxxxxxxxxx>
> ---
> 
> diff --git a/sound/sh/aica.c b/sound/sh/aica.c
> index 7c920f3..822b119 100644
> --- a/sound/sh/aica.c
> +++ b/sound/sh/aica.c
> @@ -567,7 +567,7 @@ static int load_aica_firmware(void)
>  		return err;
>  	/* write firware into memory */
>  	spu_disable();
> -	spu_memload(0, fw_entry->data, fw_entry->size);
> +	spu_memload(0, (void *)fw_entry->data, fw_entry->size);

IMO, it's better to fix spu_memload() to take const pointer instead of 
cast.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/