Re: [PATCH 1/2] Char: isicom, prolong tty reference holding

[Jiri Slaby]

On 16.3.2009 11:50, Alan Cox wrote:
> On Mon, 16 Mar 2009 11:34:24 +0100
> Jiri Slaby<jirislaby@xxxxxxxxx>  wrote:
>
> > Hold the tty reference a bit longer in isicom_shutdown_port, because
> > we use it later in the function, so that it won't disappear in the
> > meantime.
>
> NAK - we do have a bug there but I don't think that is it.
>
> The tty_kref_get takes an additional reference so the tty_port_tty_set is
> fine, but we don't then drop the kref we took temporarily. I think we
> need this:

Hmm, but the tty_port_tty_set drops the reference, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/