Re: [PATCH] kvm/x86: check KVM_REQ_TLB_FLUSH with irqs disabled

From: Avi Kivity
Date: Mon Mar 16 2009 - 14:33:25 EST


Marcelo Tosatti wrote:
BTW, I've wondered if the local_irq_enable in svm_vcpu_run is safe:

clgi();

local_irq_enable();

There is no way that an interrupt can be handled there without an exit, right?

clgi trumps sti, so all interrupts will be deferred until the guest is entered (which will cause an immediate vmexit).

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/