Re: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for DaVinci/DM6446.

[David Brownell]

I noticed a newish bug in probe() ...

On Monday 16 March 2009, Purushotam Kumar wrote:
> +       if (!pdata || pdata->wires == 4 || pdata->wires == 0)
> +               mmc->caps |= MMC_CAP_4_BIT_DATA;

So pdata may be null.  But, if it is, then ...

> +
> +       mmc->ops = &mmc_davinci_ops;
> +       mmc->f_min = 312500;
> +       mmc->f_max = 25000000;
> +       if (pdata->max_freq)
> +               mmc->f_max = pdata->max_freq;

Oops!

> +       if (pdata->caps)
> +               mmc->caps |= pdata->caps;

Double oops!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/