Re: {PATCH] x86: print out initial max_pfn_mapped

[Yinghai Lu]

H. Peter Anvin wrote:
> Yinghai Lu wrote:
>> Impact: more debug info
>>
>> check range that is mapped before init_memory_mapping().
>> also make 64bit have max_pfn_mapped assigned before that calling
>>
>> Index: linux-2.6/arch/x86/mm/init.c
>> ===================================================================
>> --- linux-2.6.orig/arch/x86/mm/init.c
>> +++ linux-2.6/arch/x86/mm/init.c
>> @@ -65,12 +65,11 @@ static void __init find_early_table_spac
>>  	 */
>>  #ifdef CONFIG_X86_32
>>  	start = 0x7000;
>> -	e820_table_start = find_e820_area(start, max_pfn_mapped<<PAGE_SHIFT,
>> -					tables, PAGE_SIZE);
>> -#else /* CONFIG_X86_64 */
>> +#else
>>  	start = 0x8000;
>> -	e820_table_start = find_e820_area(start, end, tables, PAGE_SIZE);
>>  #endif
>> +	e820_table_start = find_e820_area(start, max_pfn_mapped<<PAGE_SHIFT,
>> +					tables, PAGE_SIZE);
>>  	if (e820_table_start == -1UL)
>>  		panic("Cannot find space for the kernel page tables");
>>  
> 
> This doesn't seem to match anything anywhere in the description.
> Furthermore, why do we even have a different starting address for
> different architectures?  If anything, this starting address is way too
> low (hogging ZONE_DMA and all that...)
> 


>> also make 64bit have max_pfn_mapped assigned before that calling

so find_e820_area() could use max_pfn_mapped for 64 bit too.

for 64bit, you could use start from 16M for searching free range for left page table. right now
for 32bit, you may need to increase initial max_pfn_mapped to 32M (?) so could start searching from 16M.
need some code for head_32.S
anyway that will be another patch.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/