Re: [PATCH] kernel/irq/handle.c fix kstat_irqs_cpu and irq_to_descsymbols v2

From: Thomas Gleixner
Date: Tue Mar 17 2009 - 04:30:16 EST


On Mon, 16 Mar 2009, Mathieu Desnoyers wrote:

> * Thomas Gleixner (tglx@xxxxxxxxxxxxx) wrote:
> > Is this a contribution to the "most useless patch of the week"
> > contest ?
> >
> > You have my vote.
> >
>
> Count mine too ! :) Actually, this was not what it should look like.
> Here is my version. I am not totally convinced that the struct irq_desc
> is absolutely required, but in some include orders, it might matter.

I have not seen a compile failure report yet.

> However, the #endif around the EXPORT_SYMBOL is definitely needed.

Right.

> struct irq_desc *desc = irq_to_desc(irq);
> return desc ? desc->kstat_irqs[cpu] : 0;
> }
> -#endif
> EXPORT_SYMBOL(kstat_irqs_cpu);
> +#endif

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/