Re: [git-pull -tip] x86: cleanup 20090317

[Thomas Gleixner]

On Tue, 17 Mar 2009, Jaswinder Singh Rajput wrote:
> On Mon, 2009-03-16 at 23:33 +0100, Thomas Gleixner wrote:
> > On Tue, 17 Mar 2009, Jaswinder Singh Rajput wrote:
> > 
> > > -static struct clock_event_device pit_clockevent = {
> > > +static struct clock_event_device pit_dev = {
> > 
> >   Why do we need to change the name of the variable ? Just for fun or
> >   is pit_dev more self explaining than pit_clockevent ?
> 
> pit already means it is a clock event, but with this change:
> 
> 1. we save 8 characters per declaration
> 2. It solves various 80 characters problem

There is not a single 80 character problem in that file.

> this declaration is just few lines above the code where we are using it,
> so it will not be problem. So it seems worth to me.
> 
> If you still thinks this stinks, let me know I will revert it :-)

Yes it does. It's just a change with no value.
 
> Here is new pull request:
> 
> The following changes since commit 1f31834fbbb8de367914f044d3268c6afbfdd783:
>   Ingo Molnar (1):
>         Merge branch 'x86/mce2'
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git master
> 
> Jaswinder Singh Rajput (10):
>       x86: mpparse cleanup
>       x86: cpu/intel.c cleanup

These two are the only useful ones, but the actual code changes are
mixed into mechanical cleanup noise. We want to have that separate.

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/