Re: [PULL] x86 cpumask work

[Ingo Molnar]

* Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> On Monday 16 March 2009 19:18:02 Ingo Molnar wrote:
> > 
> > * Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> > > As the comments says, it can only be NULL during boot of the first CPU.
> > > 
> > > start_kernel -> check_bugs -> identify_boot_cpu -> identify_cpu
> > >   -> select_idle_routine.
> > > 
> > > Did you want me to panic if it fails?
> > 
> > Ah, ok. But i think it's very unobvious to embedd a "once per 
> > bootup" dynamic allocation like that. Please put it into a 
> > separate init routine instead. That way select_idle() [which 
> > runs during every CPU hotplug event] wont have this allocation.
> 
> There wasn't an obvious place to put the init; I've created one.
> 
> How's this?

looks perfect. Should i apply or do you want to send a pull 
request?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/