RE: [patch 1/5] x86, bts: detect size of DS fields

[Metzger, Markus T]

>-----Original Message-----
>From: Ingo Molnar [mailto:mingo@xxxxxxx]
>Sent: Tuesday, March 17, 2009 11:56 AM
>To: Metzger, Markus T


>the bigger problem is the runtime failure (boot warning) that i
>reported. Hence i cannot apply any new patches yet until that is
>resolved.

I found your email at lkml.org.

I think I found the problem:
  ds_request_bts() needs to allocate a small amount of memory.
  It uses GFP_KERNEL.

Hw-branch-tracer essentially does on_each_cpu(ds_request_bts()).


Since ds_request_bts() is meant to be called on the cpu that should
be traced, it should use GFP_ATOMIC to allow calls from smp_call_function()
and friends.

Would that be acceptable?

thanks and regards,
markus.

---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/