Re: [PATCH 2/7] tracing: replace TP<var> with TP_<var>

[Steven Rostedt]

On Tue, 17 Mar 2009, Christoph Hellwig wrote:

> On Tue, Mar 10, 2009 at 12:57:12AM -0400, Steven Rostedt wrote:
> > From: Steven Rostedt <srostedt@xxxxxxxxxx>
> > 
> > Impact: clean up
> > 
> > The macros TPPROTO, TPARGS, TPFMT, TPRAWFMT, and TPCMD all look a bit
> > ugly. This patch adds an underscore to their names.
> 
> Honestly I think they still look ugly.
> 
> >  DECLARE_TRACE(subsys_eventname,
> > -	TPPROTO(int firstarg, struct task_struct *p),
> > -	TPARGS(firstarg, p));
> > +	TP_PROTO(int firstarg, struct task_struct *p),
> > +	TP_ARGS(firstarg, p));
> 
> Compare that to a
> 
> DECLARE_TRACE(subsys_eventname,
> 	trace_proto(int firstarg, struct task_struct *p),
> 	trace_args(firstarg, p));
> 
> or even when you insist on UPPERCASE:
> 
> DECLARE_TRACE(subsys_eventname,
> 	TRACE_PROTO(int firstarg, struct task_struct *p),
> 	TRACE_ARGS(firstarg, p));

I have no attachement to the name. I can switch it to TRACE_PROTO etc.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/