RE: [PATCH] dmaengine: Add Kconfig of DMA data align for DMA Test driver

[Sosnowski, Maciej]

Dan Williams wrote:
> On Wed, Mar 11, 2009 at 11:30 PM, Nobuhiro Iwamatsu
> <iwamatsu.nobuhiro@xxxxxxxxxxx> wrote:
>> Test drivers of DMA engine usually perform DMA transfer by 1 byte
>> unit. This can set transfer size of DMA and aligns data for tests.
>> 
>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@xxxxxxxxxxx>
>> Cc: Haavard Skinnemoen <hskinnemoen@xxxxxxxxx>
>> Cc: Maciej Sosnowski <maciej.sosnowski@xxxxxxxxx>
>> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
>> ---
> 
> This should just be a module parameter, and it needs error handling
> for the alignment > transfer length case.
> 
> Thanks,
> Dan

I agree with Dan. Align size should be rather module parameter.

Regards,
Maciej--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/