Re: Microblaze linux support

[Ingo Molnar]

* Michal Simek <monstr@xxxxxxxxx> wrote:

> WARNING: externs should be avoided in .c files
> #92: FILE: arch/microblaze/kernel/microblaze_ksyms.c:27:
> +extern void __ashldi3(void);
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #93: FILE: arch/microblaze/kernel/microblaze_ksyms.c:28:
> +EXPORT_SYMBOL(__ashldi3);
> 
> WARNING: externs should be avoided in .c files
> #94: FILE: arch/microblaze/kernel/microblaze_ksyms.c:29:
> +extern void __ashrdi3(void);
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #95: FILE: arch/microblaze/kernel/microblaze_ksyms.c:30:
> +EXPORT_SYMBOL(__ashrdi3);
> 
> WARNING: externs should be avoided in .c files
> #96: FILE: arch/microblaze/kernel/microblaze_ksyms.c:31:
> +extern void __divsi3(void);
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #97: FILE: arch/microblaze/kernel/microblaze_ksyms.c:32:
> +EXPORT_SYMBOL(__divsi3);
> 
> WARNING: externs should be avoided in .c files
> #98: FILE: arch/microblaze/kernel/microblaze_ksyms.c:33:
> +extern void __lshrdi3(void);
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #99: FILE: arch/microblaze/kernel/microblaze_ksyms.c:34:
> +EXPORT_SYMBOL(__lshrdi3);
> 
> WARNING: externs should be avoided in .c files
> #100: FILE: arch/microblaze/kernel/microblaze_ksyms.c:35:
> +extern void __modsi3(void);
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #101: FILE: arch/microblaze/kernel/microblaze_ksyms.c:36:
> +EXPORT_SYMBOL(__modsi3);
> 
> WARNING: externs should be avoided in .c files
> #102: FILE: arch/microblaze/kernel/microblaze_ksyms.c:37:
> +extern void __mulsi3(void);
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #103: FILE: arch/microblaze/kernel/microblaze_ksyms.c:38:
> +EXPORT_SYMBOL(__mulsi3);
> 
> WARNING: externs should be avoided in .c files
> #104: FILE: arch/microblaze/kernel/microblaze_ksyms.c:39:
> +extern void __muldi3(void);
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #105: FILE: arch/microblaze/kernel/microblaze_ksyms.c:40:
> +EXPORT_SYMBOL(__muldi3);
> 
> WARNING: externs should be avoided in .c files
> #106: FILE: arch/microblaze/kernel/microblaze_ksyms.c:41:
> +extern void __ucmpdi2(void);
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #107: FILE: arch/microblaze/kernel/microblaze_ksyms.c:42:
> +EXPORT_SYMBOL(__ucmpdi2);
> 
> WARNING: externs should be avoided in .c files
> #108: FILE: arch/microblaze/kernel/microblaze_ksyms.c:43:
> +extern void __udivsi3(void);
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #109: FILE: arch/microblaze/kernel/microblaze_ksyms.c:44:
> +EXPORT_SYMBOL(__udivsi3);
> 
> WARNING: externs should be avoided in .c files
> #110: FILE: arch/microblaze/kernel/microblaze_ksyms.c:45:
> +extern void __umodsi3(void);
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #111: FILE: arch/microblaze/kernel/microblaze_ksyms.c:46:
> +EXPORT_SYMBOL(__umodsi3);

externs should be in header files.

The rest indeed looks like false positives. Thanks for addressing 
these things so quickly!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/