Re: oops in tracepoint_update_probe_range()

[Steven Rostedt]

On Thu, 19 Mar 2009, Mathieu Desnoyers wrote:

> * Ingo Molnar (mingo@xxxxxxx) wrote:
> > 
> > * Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > 
> > > On Thu, 19 Mar 2009, Mathieu Desnoyers wrote:
> > > > 
> > > > Jaswinder : maybe you have old modules in your /lib/modules/`uname -r`
> > > > directory which have the correct version, but the wrong module.h header ?
> > > 
> > > Isn't there a module versioning that prevents such things?
> > 
> > It can be overriden. In any case, the NULL check we have there now 
> > makes sense.
> > 
> > 	Ingo
> 
> Well, it duplicates the check for begin == end. Actually, if begin !=
> end _and_ being is NULL, this should be a WARN_ON or BUG_ON, because
> the kernel would be trying to load a module with incompatible struct
> module.
> 
> Are we supposed to assume that module.c allows loading modules with
> incompatible struct module at all ? That sounds like we would be trying
> to fix up things broken by the module loader in the first place.

Then it should be WARN_ON, no need to lock up a box hard, and give the 
user in X with no serial, no idea why the box just locked up.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/