Re: [PATCH] deadlock when swapping to FAT

[OGAWA Hirofumi]

Mikulas Patocka <mpatocka@xxxxxxxxxx> writes:

> It should prevent truncation under bmap. It is used by direct-io code to 
> protect the file from being truncated while there's direct-io being 
> processed on it.

I know, FAT is ok, of course, and the simple fs would also be ok.
However, it's not enough for all filesystems, in theory.

> But some filesystems do their own direct-io locking (for example XFS). So 
> I think it would be best to place the lock to generic_block_bmap, so that 
> filesystem that doesn't want the lock can easily avoid it.
>
> You can submit this patch after 2.6.29 is released.

I don't have objection to it. Please submit it yourself.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/