Re: [PATCH 20/35] Use a pre-calculated value fornum_online_nodes()

[Christoph Lameter]

On Thu, 19 Mar 2009, Mel Gorman wrote:

> >
> >  extern int nr_node_ids;
> > +extern int nr_online_nodes;
> > +extern int nr_possible_nodes;
>
> Have you tested the nr_possible_nodes aspects  of this patch? I can see
> where it gets initialised but nothing that updates it. It would appear that
> nr_possible_nodes() and num_possible_nodes() can return different values.

Right now we bypass the helper functions.... The only places where the
possible map is modified are:

./arch/x86/mm/numa_64.c:        node_set(0, node_possible_map);
./arch/x86/mm/k8topology_64.c:          node_set(nodeid, node_possible_map);
./arch/x86/mm/srat_64.c:        node_possible_map = nodes_parsed;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/