Re: [RFC Aufs2 #3 2/2] split 'xino' entry under sysfs

[hooanon05]

Greg KH:
> > +Description:
> > +		It shows the consumed blocks by xib (External Inode Number
> > +		Bitmap), its block size and file size.
> > +		When the aufs mount option 'noxino' is specified, it
> > +		will be empty. About XINO files, see
> > +		Documentation/filesystems/aufs/aufs.5 in detail.
> 
> Sysfs files are one value per file.  This violates that rule.

Current print format is 
	"%llux%lu %lld\n", st->blocks, st->blksize, (long long)st->size

Do you mean this has three values and violates the rule?
And aufs should create three entries such like xib/blocks, xib/blksize
and xib/size?
If I change it "<blocks>x<blksize>", is it still violation?


> Are all of these things something that a "normal" user would care about?
> or are they development / debugging things?

Normal users want to care them, I guess.
Since XINO files grow only, some heavy users had met ENOSPC
actually. Currently aufs supports automatic truncation for XINO files in
tmpfs only.


> And why are you using seq_file for a sysfs file?  That's not allowed,
> and a sure sign you are doing something wrong, please remove all of
> that.

I just wanted to set limit its size to PAGE_SIZE to print the absolute
path. Is there another better approach?


Thank you for reviewing
J. R. Okajima
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/