Re: [PATCH] watchdog: New library code

[Wim Van Sebroeck]

Hi Alan,

I put your new library code in a git branch called alan-generic-watchdog
in the linux-2.6-watchdog-next tree. My old code is in the branch
wim-generic-watchdog. I'm preparing a new tree with the best of both trees
in a new branch called generic-watchdog. I will sent you the merged code
for review in a couple of days.

> > > - Handles the temperature device
> > Why don't we treat the temperature part not as a hwmon?
> 
> Because the temperature interface was there first and is part of the
> existing kernel to user space API. Now that the device is abstracted I
> agree entirely that it should also appear in hwmon and the support
> library code can be extended to do this along with multiple watchdogs.

Agree.

> > > - It does all the reboot, nowayout and module locking and housekeeping
> > Why don't we use the shutdown methods of our platform and other devices instead of the reboot notifier setup?
> 
> As and when watchdogs are all platform devices we probably should. Right
> now most of them are not and we don't really have a proper 'isa_device'
> object yet. I see that as a migration path or an 'aspiration', but having
> it in one place will make that easier to achieve after we have the common
> API.

I'd rather do the conversion to a platform device and the conversion to the
new api in one go. Concerning the isa_device -> see pcwd.c . 

> Likewise sysfs, classes and multiple watchdogs all want addressing but
> that gets a lot easier once everything is using a common framework and a
> passed 'struct watchdog' to make multiple instances just work.

Agree.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/