Re: [PATCH 08/57] microblaze_v7: Interrupt handling, timer support,selfmod code

From: Thomas Gleixner
Date: Fri Mar 20 2009 - 10:12:39 EST


Michal,

On Fri, 20 Mar 2009, Michal Simek wrote:
> > I guess the problem is in your chip->xxx functions.
>
> I fixed it. There were one additional line.
> + I set GENERIC_HARDIRQS_NO__DO_IRQ=y.

Cool.

> BTW: Below is full chip description where function enable is unmask
> and disable is mask. Do I have keep there enable and disable function pointers?
> I commented them and works without them too.

Right. The generic code does:

if (!chip->enable)
chip->enable = default_enable;
if (!chip->disable)
chip->disable = default_disable;

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/