Re: [Announce] 2.6.29-rc8-rt2

[Ingo Molnar]

* Will Schmidt <will_schmidt@xxxxxxxxxxxx> wrote:

> On Fri, 2009-03-20 at 18:45 +0100, Thomas Gleixner wrote:
> > We are pleased to announce the next update to our new preempt-rt
> > series.
> >     
> >      - resurrected ARM and PowerPC support
> >      - tracing fixes for ARM (Uwe Kleine-Koenig)
> > 
> > The support for ARM/PowerPC has only been lightly tested. It might
> > crash and burn your system, make your hair curl, frigthen your cat and
> > give you sleepless nights. You have been warned !
> 
> During a build attempt on powerpc, I am seeing:
> 
> In file included from include/linux/mmzone.h:776,
>                  from include/linux/gfp.h:5,
>                  from include/linux/slab.h:13,
>                  from include/linux/percpu.h:6,
>                  from include/linux/rcupdate.h:40,
>                  from include/linux/rculist.h:11,
>                  from include/linux/dcache.h:7,
>                  from include/linux/fs.h:299,
>                  from init/do_mounts_rd.c:4:
> /root/linux-2.6.29-rc8/arch/powerpc/include/asm/mmzone.h:32: error:
> expected â=â, â,â, â;â, âasmâ or â__attribute__â before
> ânuma_cpumask_lookup_tableâ
> In file included from include/linux/topology.h:35,
>                  from include/linux/gfp.h:8,
>                  from include/linux/slab.h:13,
>                  from include/linux/percpu.h:6,
>                  from include/linux/rcupdate.h:40,
>                  from include/linux/rculist.h:11,
>                  from include/linux/dcache.h:7,
>                  from include/linux/fs.h:299,
>                  from init/do_mounts_rd.c:4:
> /root/linux-2.6.29-rc8/arch/powerpc/include/asm/topology.h: In function
> ânode_to_cpumaskâ:
> /root/linux-2.6.29-rc8/arch/powerpc/include/asm/topology.h:22: error:
> ânuma_cpumask_lookup_tableâ undeclared (first use in this function)
> /root/linux-2.6.29-rc8/arch/powerpc/include/asm/topology.h:22: error:
> (Each undeclared identifier is reported only once
> /root/linux-2.6.29-rc8/arch/powerpc/include/asm/topology.h:22: error:
> for each function it appears in.)
> /root/linux-2.6.29-rc8/arch/powerpc/include/asm/topology.h: In function
> ânode_to_first_cpuâ:
> /root/linux-2.6.29-rc8/arch/powerpc/include/asm/topology.h:29: error:
> ânuma_cpumask_lookup_tableâ undeclared (first use in this function)
> make[1]: *** [init/do_mounts_rd.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> 
> 
> 
> I have locally fixed by adding an include just above the cpumask_t
> reference.  The include may belong elsewhere, but in case I got it
> right,.. :-)
> 
> Signed-Off-By:  Will Schmidt <will_schmidt@xxxxxxxxxxxx>

you got it right :-) The full fix (the bug also affects sparc) is 
already queued up - see it below.

	Ingo

-------------->