Re: [PATCH 06/13] async_tx: add support for asynchronous GF multiplication

From: H. Peter Anvin
Date: Fri Mar 20 2009 - 18:44:24 EST


Dan Williams wrote:

Something is broken if we take this path. This routine could stand to
have a WARN_ONCE(), because if it is ever called there is something is
wrong with the raid6 offload driver. The intent is that the
asynchronous recovery routines will perform an early check to see if
the recovery can be offloaded (with a series of calls to
async_xor/async_pq). If not we fall back to the optimized synchronous
recovery routines (raid6_2data_recov, raid6_datap_recov). The only
time this path will be taken is if we have decided to perform
asynchronous recovery but at a later call to async_pq the offload
driver reports it has run out of descriptors.


That doesn't explain what you expect the code to do. It still doesn't make sense to me.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/