Re: [PATCH 1/1] Restrict definitions of a couple of staticfunctions

[Ingo Molnar]

* Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxxx> wrote:

> The call sites of the static functions free_cache_attributes() and
> detect_cache_attributes() in arch/x86/kernel/cpu/intel_cacheinfo.c
> are placed under #ifdef CONFIG_SYSFS/#endif, but their definitions
> are not. This may produce the following warning:
> 
> arch/x86/kernel/cpu/intel_cacheinfo.c:542: warning:
> 'free_cache_attributes' defined but not used
> arch/x86/kernel/cpu/intel_cacheinfo.c:573: warning:
> 'detect_cache_attributes' defined but not used
> 
> This patch fixes the warning by restricting the definitions of the
> two functions to the case when CONFIG_SYSFS is enabled.
> 
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxxx>
> ---
>  arch/x86/kernel/cpu/intel_cacheinfo.c |   64 ++++++++++++++++----------------
>  1 files changed, 32 insertions(+), 32 deletions(-)

does not apply to the latest x86 tree anymore:

  http://people.redhat.com/mingo/tip.git/README

2 out of 3 hunks FAILED -- rejects in file arch/x86/kernel/cpu/intel_cacheinfo.c

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/