Re: [PATCH 06/13] async_tx: add support for asynchronous GF multiplication

[Dan Williams]

On Sat, Mar 21, 2009 at 12:15 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> Why does it?  I don't see why you'd need to cover the vector-vector case
> at all, since it doesn't appear anywhere in the algorithms.  Certainly
> going backwards from a vector-vector set to derive if you can do a
> scalar-vector multiply when you should have known that in the first
> place is not really useful.
>
>>
>> Looking closer, the only other caller, async_pq_zero_sum, can be
>> deleted because it has no users.  So async_pq can become a static
>> routine in async_r6recov.
>>
>
> That's another issue entirely, of course :)
>

...ah, but now I see your point and the root cause of the problem.
The caller needs to be modified to only require scalar multiplication
even in this corner case.

Thanks,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/