Re: [PATCH 7/8] exofs: Documentation

[Boaz Harrosh]

Evgeniy Polyakov wrote:
> Hi.
> 
> On Wed, Mar 18, 2009 at 08:10:58PM +0200, Boaz Harrosh (bharrosh@xxxxxxxxxxx) wrote:
>> +++ b/fs/exofs/BUGS
>> @@ -0,0 +1,3 @@
>> +- Out-of-space may cause a severe problem if the object (and directory entry)
>> +  were written, but the inode attributes failed. Then if the filesystem was
>> +  unmounted and mounted the kernel can get into an endless loop doing a readdir.
> 
> Does it also mean that damaged media may end up freezing the machine
> during the mount?
> 

I had such situation and it was able to mount. Some data was lost.

But sure, if the damage was in a way like above it would. The bad
situation is when there is a directory entry, there is a corresponding
object, but there is an error reading the associated attribute. the
redir code does not expect to fail, independent from iget()

It is difficult for me to repeat this problem because I've changed
the osd-target I'm running with, and with the new target attributes
are stored an a DB, so the create-object fails with ENOSP long before
I'm no longer able to write attributes. But I'm sure one day this problem
will come to hunt me.

Thanks
Boaz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/